Skip to content

storing lolcommits directly in git #40

Open
windo opened this Issue May 17, 2012 · 9 comments

8 participants

@windo
windo commented May 17, 2012

possibly the image could be stored by cgit:
git notes --ref lolcommits add --file=<image>

i didn't notice the git gem supporting git notes atm. next step would obviously be to request github to show the lolcommits from repos. they currently support text notes (https://github.com/blog/707-git-notes-display), but no mention of image notes (yet!), didn't try either though.

@mroth
Owner
mroth commented May 18, 2012

Huh, this is really interesting, I wasn't aware of the notes functionality. Really cool. Perhaps in conjunction with a URL of an image once upload is added (see #33 and #39).

Does Github support markdown display in git notes?

@nohn
nohn commented May 18, 2012

But please make it configurable. You may not want to upload your lolcommits for every repository you have enable lolcommits for nor may you want to upload every lolcommit.

@mroth
Owner
mroth commented May 18, 2012

@nohn when image upload is added, it will definitely be optional (and auto-upload off by default).

@prydonius

If you wanted to do upload based on commit, you could have some sort of tag at the end of the message (except that you could forget) or a prompt before it takes a snap (which could get annoying).

@BarryCarlyon

On a side note, you can just add code to the post-commit hook.

I have mine on commit, grabbing the file name, rsyncing to a server, and then auto posting to works internal chat room.

@prydonius

But you might want to choose which commits you want to upload even in one project.

@Hunter-Dolan

We use this modified Post-Commit script to append our lolcommit images to each of our commits.

Hopefully this can help someone (It's pretty dirty code but it gets the job done, assumes you're using github)

https://gist.github.com/4579913

@bassrock

It would also be cool to configure a separate git repo, just for the lol commits. Keeping them in the repo of the code may be too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.