Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for using the password grant with a confidential client #114

Merged
merged 3 commits into from Jun 4, 2019

Conversation

@alexashley
Copy link
Collaborator

commented May 23, 2019

The current implementation only allows direct access grants with a public client.

@@ -43,13 +43,13 @@ func NewKeycloakClient(baseUrl, clientId, clientSecret, realm, username, passwor
}
clientCredentials := &ClientCredentials{
ClientId: clientId,
ClientSecret: clientSecret,

This comment has been minimized.

Copy link
@alexashley

alexashley May 23, 2019

Author Collaborator

The zero value for a string is the empty string, so this shouldn't affect public clients.

alexashley and others added 2 commits May 23, 2019
@mrparkers mrparkers merged commit dae3710 into master Jun 4, 2019
2 checks passed
2 checks passed
ci/circleci: test-client-credentials Your tests passed on CircleCI!
Details
ci/circleci: test-password Your tests passed on CircleCI!
Details
@mrparkers mrparkers deleted the password-client-secret branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.