Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build with mrpt 2.0 #41

Merged
merged 2 commits into from Apr 21, 2018

Conversation

Projects
None yet
3 participants
@MaxGsomGsom
Copy link
Contributor

commented Apr 21, 2018

Tested with:
-Ubuntu Xenial
-gcc7
-Latest binary of MRPT 1.9.9
-Latest source of mrpt_navigation

@MaxGsomGsom MaxGsomGsom force-pushed the MaxGsomGsom:master branch 5 times, most recently from 189b830 to ffec3d3 Apr 21, 2018

@bergercookie
Copy link
Member

left a comment

Hey @MaxGsomGsom,

Thanks for this contribution.

Only thing I can notice is that the indentation in the modified lines seems to be wrong. Have you set up your editor according to the directives of this document?

@MaxGsomGsom MaxGsomGsom force-pushed the MaxGsomGsom:master branch 2 times, most recently from 648873a to 818a878 Apr 21, 2018

@MaxGsomGsom MaxGsomGsom force-pushed the MaxGsomGsom:master branch 4 times, most recently from 7385835 to 031cbea Apr 21, 2018

@MaxGsomGsom

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2018

Ok, I fixed it

@jlblancoc

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

@jlblancoc jlblancoc merged commit 14ac5a9 into mrpt-ros-pkg:master Apr 21, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jlblancoc

This comment has been minimized.

Copy link
Member

commented Apr 21, 2018

Merged, thanks! Travis still shows errors for both mrpt-1.5 and mrpt-2.0, but we'll address them next...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.