MongoID 3.0 compatibility + refactoring #31

Closed
wants to merge 4 commits into
from

Projects

None yet

4 participants

@MadRabbit

Hey Michael,

I've added a patch for mongoid 3.0 compatibility + refactoring things a bit, moved the include Paperclip calls into the self.include section where it belongs to.

Also, if you don't mind i've made the original has_attached_file method work, it seems a bit silly to define your own method in this case.

Cheers,
Nik

@Proghat

You wrote that Mongoid 3 doesn't have logger. Why did you leave that line there?

Owner

in case someone still uses it with mongoid 2

@Proghat
Proghat commented Jul 22, 2012

What does that syntax mean?

begin
  first
else
  second
end
@MadRabbit

regarding begin - rescue that's a try/catch for ruby

@Proghat
Proghat commented Jul 22, 2012

Is it work for you? Shoult not it raise exception to upper level if no rescue block found? I made little experiment: https://gist.github.com/3160000

@MadRabbit

i've checked, this one works :)

@mshibuya
Contributor

For Mongoid3 logger issue, I've submitted the pull request #25, which have already been merged into develop branch(not master).

@sdhull
Collaborator
sdhull commented Jan 29, 2014

If this is still relevant, close this PR and make a new PR into develop (after rebasing your branch on develop), so it can apply cleanly.

Sorry it took so long to review. Once upon a time I made a contributor for this repo, but have since moved to using carrierwave with mongoid. At any rate since I have commit rights, I feel somewhat obligated to review PRs, but it's not exactly high on my list of priorities.

@sdhull
Collaborator
sdhull commented Feb 21, 2014

Yeah I don't think this is still relevant. Closing for now. Comment if I'm off base here.

@sdhull sdhull closed this Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment