Use the standard CMake-flag BUILD_SHARED_LIBS. #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPILE_TYPE is left in for backwards compatibility.
Owner
|
thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPILE_TYPEis left in for backwards compatibility.Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.
CMake compatibilty
BUILD_SHARED_LIBSis availbale in CMake 3.10:https://cmake.org/cmake/help/v3.10/variable/BUILD_SHARED_LIBS.html
Reasoning
Will make life easier for package maintainers and CMake users who already know
about that flag immediately recognize it's function.