From 7fbbbe743ff8d02af190d1cc6a53d209ce683413 Mon Sep 17 00:00:00 2001 From: Marc Zych Date: Mon, 18 Apr 2016 11:03:58 -0700 Subject: [PATCH] Connection: Initialize timeout and followRedirects This fixes the following Valgrind failure: ``` ==6158== Conditional jump or move depends on uninitialised value(s) ==6158== at 0x4738F2: RestClient::Connection::performCurlRequest(std::string const&) (REDACTED) ==6158== by 0x473D10: RestClient::Connection::get(std::string const&) (REDACTED) ==6158== by 0x472779: RestClient::get(std::string const&) (REDACTED) ==6158== by 0x40E59F: RestClientCpp_Http_Test::TestBody() (REDACTED) ==6158== by 0x447798: void testing::internal::HandleExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*) (REDACTED) ==6158== by 0x43A2CE: testing::Test::Run() (REDACTED) ==6158== by 0x43A38C: testing::TestInfo::Run() (REDACTED) ==6158== by 0x43A4A4: testing::TestCase::Run() (REDACTED) ==6158== by 0x43A757: testing::internal::UnitTestImpl::RunAllTests() (REDACTED) ==6158== by 0x43A9F8: testing::UnitTest::Run() (REDACTED) ==6158== by 0x40C99F: main (REDACTED) ==6158== { Memcheck:Cond fun:_ZN10RestClient10Connection18performCurlRequestERKSs fun:_ZN10RestClient10Connection3getERKSs fun:_ZN10RestClient3getERKSs fun:_ZN23RestClientCpp_Http_Test8TestBodyEv fun:_ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc fun:_ZN7testing4Test3RunEv fun:_ZN7testing8TestInfo3RunEv fun:_ZN7testing8TestCase3RunEv fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv fun:_ZN7testing8UnitTest3RunEv fun:main } ``` --- source/connection.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/connection.cc b/source/connection.cc index 25163a6d..7c4a5c91 100644 --- a/source/connection.cc +++ b/source/connection.cc @@ -31,6 +31,8 @@ RestClient::Connection::Connection(const std::string baseUrl) throw std::runtime_error("Couldn't initialize curl handle"); } this->baseUrl = baseUrl; + this->timeout = 0; + this->followRedirects = false; } RestClient::Connection::~Connection() {