Skip to content

Commit 192e6e3

Browse files
committed
mruby-print/print.c: remove internal method __printstr
Instead, implement `print` method in C and use it from mrblib/print.rb
1 parent bd41dfb commit 192e6e3

2 files changed

Lines changed: 24 additions & 27 deletions

File tree

mrbgems/mruby-print/mrblib/print.rb

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,12 @@ def p(*args)
1212
i = 0
1313
len = args.size
1414
while i < len
15-
__printstr args[i].inspect
16-
__printstr "\n"
15+
print args[i].inspect, "\n"
1716
i += 1
1817
end
1918
args.__svalue
2019
end
2120

22-
# ISO 15.3.1.2.10 Kernel.print
23-
# ISO 15.3.1.3.35 Kernel#print
24-
def print(*args)
25-
i = 0
26-
len = args.size
27-
while i < len
28-
__printstr args[i].to_s
29-
i += 1
30-
end
31-
end
32-
3321
# ISO 15.3.1.2.11 Kernel.puts
3422
# ISO 15.3.1.3.39 Kernel#puts
3523
def puts(*args)
@@ -40,16 +28,15 @@ def puts(*args)
4028
if s.kind_of?(Array)
4129
puts(*s)
4230
else
43-
s = s.to_s
44-
__printstr s
45-
__printstr "\n" if (s[-1] != "\n")
31+
print s
32+
print "\n" if (s[-1] != "\n")
4633
end
4734
i += 1
4835
end
49-
__printstr "\n" if len == 0
36+
print "\n" if len == 0
5037
end
5138

5239
def printf(*args)
53-
__printstr(sprintf(*args))
40+
print(sprintf(*args))
5441
end
5542
end

mrbgems/mruby-print/src/print.c

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@
1515
#endif
1616
#endif
1717

18-
static mrb_value
19-
mrb_printstr(mrb_state *mrb, mrb_value self)
18+
static void
19+
printstr(mrb_state *mrb, mrb_value s)
2020
{
21-
mrb_value s = mrb_get_arg1(mrb);
22-
2321
if (mrb_string_p(s)) {
2422
const char *p = RSTRING_PTR(s);
2523
mrb_int len = RSTRING_LEN(s);
@@ -35,21 +33,33 @@ mrb_printstr(mrb_state *mrb, mrb_value self)
3533
utf16, (DWORD)wlen, &written, NULL);
3634
}
3735
mrb_free(mrb, utf16);
36+
return;
3837
}
39-
else
4038
#endif
41-
{
42-
fwrite(p, (size_t)len, 1, stdout);
43-
}
39+
fwrite(p, (size_t)len, 1, stdout);
4440
fflush(stdout);
4541
}
42+
}
43+
44+
// ISO 15.3.1.2.10 Kernel.print
45+
// ISO 15.3.1.3.35 Kernel#print
46+
static mrb_value
47+
mrb_print(mrb_state *mrb, mrb_value self)
48+
{
49+
mrb_int argc = mrb_get_argc(mrb);
50+
const mrb_value *argv = mrb_get_argv(mrb);
51+
52+
for (mrb_int i=0; i<argc; i++) {
53+
mrb_value str = mrb_obj_as_string(mrb, argv[i]);
54+
printstr(mrb, str);
55+
}
4656
return mrb_nil_value();
4757
}
4858

4959
void
5060
mrb_mruby_print_gem_init(mrb_state* mrb)
5161
{
52-
mrb_define_method(mrb, mrb->kernel_module, "__printstr", mrb_printstr, MRB_ARGS_REQ(1));
62+
mrb_define_method(mrb, mrb->kernel_module, "print", mrb_print, MRB_ARGS_ANY()); /* 15.3.1.3.35 */
5363
}
5464

5565
void

0 commit comments

Comments
 (0)