str_buf_cat(): better size check added; ref #3342

mruby · Dec 31, 2016 · 1ed4de5 · 1ed4de5
1 parent 342b1de
commit 1ed4de5
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/string.c b/src/string.c
@@ -163,15 +163,20 @@ str_buf_cat(mrb_state *mrb, struct RString *s, const char *ptr, size_t len)
 
   total = RSTR_LEN(s)+len;
   if (total >= MRB_INT_MAX) {
+  size_error:
     mrb_raise(mrb, E_ARGUMENT_ERROR, "string size too big");
   }
   if (capa <= total) {
     while (total > capa) {
-      if (capa + 1 >= MRB_INT_MAX / 2) {
-        capa = MRB_INT_MAX;
-        break;
+      if (capa <= MRB_INT_MAX / 2) {
+        capa *= 2;
+      }
+      else {
+        goto size_error;
       }
-      capa = (capa + 1) * 2;
+    }
+    if (capa < total || capa > MRB_INT_MAX) {
+      goto size_error;
     }
     resize_capa(mrb, s, capa);
   }