Skip to content

Commit 4a0e806

Browse files
committed
mruby-kernel-ext: make Kernel methods private
- fail - caller = __method__ - __callee__ - Integer = Float - String - Array - Hash
1 parent 93e1335 commit 4a0e806

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

mrbgems/mruby-kernel-ext/src/kernel.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -270,17 +270,17 @@ mrb_mruby_kernel_ext_gem_init(mrb_state *mrb)
270270
{
271271
struct RClass *krn = mrb->kernel_module;
272272

273-
mrb_define_module_function_id(mrb, krn, MRB_SYM(fail), mrb_f_raise, MRB_ARGS_OPT(2));
274-
mrb_define_module_function_id(mrb, krn, MRB_SYM(caller), mrb_f_caller, MRB_ARGS_OPT(2));
275-
mrb_define_method_id(mrb, krn, MRB_SYM(__method__), mrb_f_method, MRB_ARGS_NONE());
276-
mrb_define_method_id(mrb, krn, MRB_SYM(__callee__), mrb_f_callee, MRB_ARGS_NONE());
277-
mrb_define_module_function_id(mrb, krn, MRB_SYM(Integer), mrb_f_integer, MRB_ARGS_ARG(1,1));
273+
mrb_define_private_method_id(mrb, krn, MRB_SYM(fail), mrb_f_raise, MRB_ARGS_OPT(2));
274+
mrb_define_private_method_id(mrb, krn, MRB_SYM(caller), mrb_f_caller, MRB_ARGS_OPT(2));
275+
mrb_define_private_method_id(mrb, krn, MRB_SYM(__method__), mrb_f_method, MRB_ARGS_NONE());
276+
mrb_define_private_method_id(mrb, krn, MRB_SYM(__callee__), mrb_f_callee, MRB_ARGS_NONE());
277+
mrb_define_private_method_id(mrb, krn, MRB_SYM(Integer), mrb_f_integer, MRB_ARGS_ARG(1,1));
278278
#ifndef MRB_NO_FLOAT
279-
mrb_define_module_function_id(mrb, krn, MRB_SYM(Float), mrb_f_float, MRB_ARGS_REQ(1));
279+
mrb_define_private_method_id(mrb, krn, MRB_SYM(Float), mrb_f_float, MRB_ARGS_REQ(1));
280280
#endif
281-
mrb_define_module_function_id(mrb, krn, MRB_SYM(String), mrb_f_string, MRB_ARGS_REQ(1));
282-
mrb_define_module_function_id(mrb, krn, MRB_SYM(Array), mrb_f_array, MRB_ARGS_REQ(1));
283-
mrb_define_module_function_id(mrb, krn, MRB_SYM(Hash), mrb_f_hash, MRB_ARGS_REQ(1));
281+
mrb_define_private_method_id(mrb, krn, MRB_SYM(String), mrb_f_string, MRB_ARGS_REQ(1));
282+
mrb_define_private_method_id(mrb, krn, MRB_SYM(Array), mrb_f_array, MRB_ARGS_REQ(1));
283+
mrb_define_private_method_id(mrb, krn, MRB_SYM(Hash), mrb_f_hash, MRB_ARGS_REQ(1));
284284
}
285285

286286
void

mrbgems/mruby-kernel-ext/test/kernel.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
assert('Kernel.fail, Kernel#fail') do
1+
assert('Kernel#fail') do
22
assert_raise(RuntimeError) { fail }
3-
assert_raise(RuntimeError) { Kernel.fail }
43
end
54

65
assert('Kernel.caller, Kernel#caller') do
@@ -121,10 +120,10 @@ def m1; __callee__ end
121120
end
122121

123122
assert('Kernel#Array') do
124-
assert_equal([1], Kernel.Array(1))
125-
assert_equal([1, 2, 3, 4, 5], Kernel.Array([1, 2, 3, 4, 5]))
126-
assert_equal([1, 2, 3, 4, 5], Kernel.Array(1..5))
127-
assert_equal([[:a, 1], [:b, 2], [:c, 3]], Kernel.Array({a:1, b:2, c:3}))
123+
assert_equal([1], Array(1))
124+
assert_equal([1, 2, 3, 4, 5], Array([1, 2, 3, 4, 5]))
125+
assert_equal([1, 2, 3, 4, 5], Array(1..5))
126+
assert_equal([[:a, 1], [:b, 2], [:c, 3]], Array({a:1, b:2, c:3}))
128127
end
129128

130129
assert('Kernel#Hash') do

0 commit comments

Comments
 (0)