Permalink
Browse files

Fix crash when exponent is -2147483648

  • Loading branch information...
clayton-shopify committed Dec 15, 2016
1 parent 73cc087 commit 868d2e528fce86f380a2d099877f6cb8ffd1ff69
Showing with 12 additions and 1 deletion.
  1. +8 −1 src/string.c
  2. +4 −0 test/t/string.rb
View
@@ -2868,7 +2868,11 @@ mrb_float_read(const char *string, char **endPtr)
mantSize -= 1; /* One of the digits was the point. */
}
if (mantSize > 18) {
fracExp = decPt - 18;
if (decPt - 18 > 29999) {
fracExp = 29999;
} else {
fracExp = decPt - 18;
}
mantSize = 18;
} else {
fracExp = decPt - mantSize;
@@ -2922,6 +2926,9 @@ mrb_float_read(const char *string, char **endPtr)
}
while (isdigit(*p)) {
exp = exp * 10 + (*p - '0');
if (exp > 19999) {
exp = 19999;
}
p += 1;
}
}
View
@@ -596,10 +596,14 @@ def to_str
a = ''.to_f
b = '123456789'.to_f
c = '12345.6789'.to_f
d = '1e-2147483648'.to_f
e = '1e2147483648'.to_f
assert_float(0.0, a)
assert_float(123456789.0, b)
assert_float(12345.6789, c)
assert_float(0, d)
assert_float(Float::INFINITY, e)
end
assert('String#to_i', '15.2.10.5.39') do

0 comments on commit 868d2e5

Please sign in to comment.