Skip to content

Commit

Permalink
void_expr_error(): n may be NULL.
Browse files Browse the repository at this point in the history 
Reported from @clayton-shopify.
  • Loading branch information
@matz
matz committed Dec 13, 2016
1 parent 3bedd22 commit d196e4d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions mrbgems/mruby-compiler/core/parse.y
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3430,6 +3430,7 @@ void_expr_error(parser_state *p, node *n)
{
int c;

if (n == NULL) return;
c = (int)(intptr_t)n->car;
switch (c) {
case NODE_BREAK:
Expand Down

3 comments on commit d196e4d

@clayton-shopify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally reported by https://hackerone.com/revskills

@matz
Copy link
Member Author

@matz matz commented on d196e4d Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good way to keep attribution like this?

@clayton-shopify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be disclosing the HackerOne tickets of any researcher who wants that, so that should be sufficient. I just commented here so it would be clear that I wasn't the discoverer of this issue.

Please sign in to comment.