Permalink
Browse files

Add forgotten loop_pop() in NODE_OP_ASGN codegen

  • Loading branch information...
matz committed Nov 24, 2016
1 parent f5a86ca commit dc4be19aab7df7b3d31102a68c4ed12c63a5814c
Showing with 1 addition and 0 deletions.
  1. +1 −0 mrbgems/mruby-compiler/core/codegen.c
@@ -1746,6 +1746,7 @@ codegen(codegen_scope *s, node *tree, int val)
genop(s, MKOP_A(OP_RESCUE, exc));
genop(s, MKOP_A(OP_LOADF, exc));
dispatch(s, noexc);
loop_pop(s, NOVAL);
}
else if ((intptr_t)tree->car->car == NODE_CALL) {
node *n = tree->car->cdr;

2 comments on commit dc4be19

@bouk

This comment has been minimized.

Show comment
Hide comment
@bouk

bouk Nov 24, 2016

Contributor

@matz would it be possible to merge in the test too for cases like this?

Contributor

bouk replied Nov 24, 2016

@matz would it be possible to merge in the test too for cases like this?

@matz

This comment has been minimized.

Show comment
Hide comment
@matz

matz Nov 24, 2016

Member

Unfortunately, I have added "void value expression" check that makes the original test code A ||= break while break a syntax error.

Member

matz replied Nov 24, 2016

Unfortunately, I have added "void value expression" check that makes the original test code A ||= break while break a syntax error.

Please sign in to comment.