Check return value from snprintf(); ref #3498

matz · matz · commit e3922318bd26 · 2017-03-11T15:18:41.000+09:00
diff --git a/mrbgems/mruby-sprintf/src/sprintf.c b/mrbgems/mruby-sprintf/src/sprintf.c
@@ -1087,6 +1087,9 @@ mrb_str_format(mrb_state *mrb, int argc, const mrb_value *argv, mrb_value fmt)
 
         CHECK(need);
         n = snprintf(&buf[blen], need, fbuf, fval);
+        if (n < 0) {
+          mrb_raise(mrb, E_RUNTIME_ERROR, "formatting error");
+        }
         blen += n;
       }
       break;

Original file line number	Diff line number	Diff line change
`@@ -1087,6 +1087,9 @@ mrb_str_format(mrb_state mrb, int argc, const mrb_value argv, mrb_value fmt)`
`1087`	`1087`
`1088`	`1088`	`CHECK(need);`
`1089`	`1089`	`n = snprintf(&buf[blen], need, fbuf, fval);`
	`1090`	`+ if (n < 0) {`
	`1091`	`+ mrb_raise(mrb, E_RUNTIME_ERROR, "formatting error");`
	`1092`	`+ }`
`1090`	`1093`	`blen += n;`
`1091`	`1094`	`}`
`1092`	`1095`	`break;`