Should not deallocate shared string referring static; fix #3373

mruby · Jan 6, 2017 · f53f73f30ca390d27994e9092ff9b6b18aa615bf · f53f73f
1 parent 36f5b44
commit f53f73f30ca390d27994e9092ff9b6b18aa615bf
Unified Split

Showing with 1 addition and 1 deletion.

+1 −1 src/string.c
diff --git a/src/string.c b/src/string.c
@@ -669,7 +669,7 @@ mrb_str_modify(mrb_state *mrb, struct RString *s)
  if (RSTR_SHARED_P(s)) {
    mrb_shared_string *shared = s->as.heap.aux.shared;

-    if (shared->refcnt == 1 && s->as.heap.ptr == shared->ptr) {
+    if (shared->nofree == 0 && shared->refcnt == 1 && s->as.heap.ptr == shared->ptr) {
      s->as.heap.ptr = shared->ptr;
      s->as.heap.aux.capa = shared->len;
      RSTR_PTR(s)[s->as.heap.len] = '\0';