protect NoMethodError from calling to_hash in replace

mruby · Jan 27, 2016 · f5f48d9 · f5f48d9
1 parent 2723b10
commit f5f48d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/mrblib/hash.rb b/mrblib/hash.rb
@@ -154,6 +154,7 @@ def each_value(&block)
   #
   # ISO 15.2.13.4.23
   def replace(hash)
+    raise TypeError, "can't convert argument into Hash" unless hash.respond_to?(:to_hash)
     self.clear
     hash = hash.to_hash
     hash.each_key{|k|

diff --git a/test/t/hash.rb b/test/t/hash.rb
@@ -239,6 +239,10 @@
   a = Hash.new{|h,x| x}
   b.replace(a)
   assert_equal(127, b[127])
+
+   assert_raise(TypeError) do
+    { 'abc_key' => 'abc_value' }.replace "a"
+  end
 end
 
 assert('Hash#shift', '15.2.13.4.24') do