New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrbc puts broken bytecode if MRB_PARSER_BUF_SIZE >= 65536 #1596

Closed
click3 opened this Issue Nov 24, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@click3
Copy link

click3 commented Nov 24, 2013

mrbc outputs broken bytecodes when MRB_PARSER_BUF_SIZE and the length of string literal in the code are larger than 65535.

This issue cause of :
MRB_PARSER_BUF_SIZE is defined as macro now and compare to the length of string literal.
size of string literal is defined as int.
However, the maximum length of the string literal is limited to 65535 in bytecode.

The solution:
We will force minirake to report error when MRB_PARSER_SIZE is larger than 65535.
(or we'll force mrbc to report error when both of the cause is satisfied.)

@matz

This comment has been minimized.

Copy link
Member

matz commented Nov 24, 2013

Or maybe we can remove MRB_PARSER_BUF_SIZE configuration.

@matz matz closed this in ed0d9f0 Nov 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment