New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sprintf error on ARMv7 with MRB_INT64 #3076

Closed
kazuho opened this Issue Jan 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kazuho
Contributor

kazuho commented Jan 7, 2016

I get following error when running make test on 32-bit ARM with MRB_INT64.

Fail: String#% (mrbgems: mruby-sprintf)
 - Assertion[1] Failed: Expected to be equal
    Expected: "one=1"
      Actual: "one=0"
 - Assertion[2] Failed: Expected to be equal
    Expected: "1 one 1.0"
      Actual: "0 one 1.0"

I assume this is because the implementation unconditionally uses sprintf "%l?" to stringify the value at line https://github.com/mruby/mruby/blob/master/mrbgems/mruby-sprintf/src/sprintf.c#L858.

@matz

This comment has been minimized.

Show comment
Hide comment
@matz

matz Jan 7, 2016

Member

@kazuho could you check the new code 7c82bfa?

Member

matz commented Jan 7, 2016

@kazuho could you check the new code 7c82bfa?

@kazuho

This comment has been minimized.

Show comment
Hide comment
@kazuho

kazuho Jan 7, 2016

Contributor

Thank you for the quick fix! Confirmed that the issue has been solved.

Contributor

kazuho commented Jan 7, 2016

Thank you for the quick fix! Confirmed that the issue has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment