New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack size calculation error in mrb_funcall_with_block? #3398

Closed
clayton-shopify opened this Issue Jan 11, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@clayton-shopify
Contributor

clayton-shopify commented Jan 11, 2017

The following input demonstrates a crash:

class A
  def initialize
  end
end

A.new *([0]*200)

This results in a heap buffer overflow in stack_copy, which is called from here:

mruby/src/vm.c

Line 407 in db1bd07

stack_copy(mrb->c->stack+1, argv, argc);

Maybe the size of the stack was calculated incorrectly?

This issue was reported by https://hackerone.com/ssarong

@matz matz closed this in a357124 Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment