Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null pointer dereference in mrb_str_modify #3407

Closed
clayton-shopify opened this issue Jan 21, 2017 · 0 comments
Closed

Null pointer dereference in mrb_str_modify #3407

clayton-shopify opened this issue Jan 21, 2017 · 0 comments

Comments

@clayton-shopify
Copy link
Contributor

The following input demonstrates a crash:

a = String.new
a[0]
GC.start
a.upcase!

The crash occurs at this line, where s->as.heap.len is NULL:

mruby/src/string.c

Line 676 in bd50273

RSTR_PTR(s)[s->as.heap.len] = '\0';

This issue was reported by https://hackerone.com/marotagem_vrt
@matz matz closed this as completed in 708088c Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clayton-shopify