New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in print_backtrace due to missing type check #3408

Closed
clayton-shopify opened this Issue Jan 21, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@clayton-shopify
Contributor

clayton-shopify commented Jan 21, 2017

The following input demonstrates a crash:

exc = Exception.new
exc.set_backtrace([0])
raise exc

The crash occurs when print_backtrace treats the fixnum as if it was a string here:

fprintf(stream, "\t[%d] %.*s\n", i, (int)RSTRING_LEN(entry), RSTRING_PTR(entry));

IRB checks the array in set_backtrace:

-:2:in `set_backtrace': backtrace must be Array of String (TypeError)
	from -:2:in `<main>'

This issue was reported by https://hackerone.com/tunz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment