Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure in mrb_gc_mark #3550

Closed
clayton-shopify opened this issue Mar 27, 2017 · 3 comments
Closed

Assertion failure in mrb_gc_mark #3550

clayton-shopify opened this issue Mar 27, 2017 · 3 comments

Comments

@clayton-shopify
Copy link
Contributor

@clayton-shopify clayton-shopify commented Mar 27, 2017

The following input demonstrates a crash:

f = Fiber.new do
    m = Fiber.current
    Fiber.yield Proc.new {}
end

f = f.resume
GC.start

Result:

Assertion failed: ((obj)->tt != MRB_TT_FREE), function mrb_gc_mark, file /Users/clayton/git/mruby/src/gc.c, line 698.
Abort trap: 6

This issue was reported by Dinko Galetic and Denis Kasak (https://hackerone.com/dgaletic). They believe the issue was introduced by ecee8c5.

@matz
Copy link
Member

@matz matz commented Apr 10, 2017

I couldn't reproduce the problem (even with GC_STRESS). Hopefully it's already fixed.

@clayton-shopify
Copy link
Contributor Author

@clayton-shopify clayton-shopify commented Apr 10, 2017

@matz This still crashes for me on the latest master. I just tested on OS X and Ubuntu.

@clayton-shopify
Copy link
Contributor Author

@clayton-shopify clayton-shopify commented Apr 10, 2017

Building with MRB_GC_STRESS makes the crash go away, so you need to build without that.

@matz matz closed this as completed in 6dd1a57 Apr 11, 2017
matz added a commit that referenced this issue Apr 18, 2017
The fix was wrong. It causes a new problem #3612.
matz added a commit that referenced this issue Apr 18, 2017
Shared TT_ENV should be unshared. Reversed condition.
matz added a commit that referenced this issue Apr 22, 2017
Reopens #3550. Those 2 issues are exclusive.
matz added a commit that referenced this issue Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants