Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow loops in time_alloc #3561

Closed
clayton-shopify opened this issue Mar 28, 2017 · 0 comments
Closed

Slow loops in time_alloc #3561

clayton-shopify opened this issue Mar 28, 2017 · 0 comments

Comments

@clayton-shopify
Copy link
Contributor

#3546 addressed some of the problems with time_alloc but processing is still slow with inputs that have a large microsecond value, e.g.:

Time.at(0, 1e15)
Time.at(0, -1e15)

CRuby handles these cases efficiently with division: https://github.com/ruby/ruby/blob/8234c571a7758e19699542c68f194c0451059466/time.c#L2134-L2149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clayton-shopify