Skip to content

Fix behavior Hash#eql? #1823

Merged
merged 1 commit into from Mar 7, 2014

2 participants

@ksss
ksss commented Mar 7, 2014

This behavior specification of mruby?

> 1.eql?(1.0)
 => false
> [1].eql?([1.0])
 => false
> {a:1}.eql?({a:1.0})
 => true

I think it's should be that.

> 1.eql?(1.0)
 => false
> [1].eql?([1.0])
 => false
> {a:1}.eql?({a:1.0})
 => false
@matz matz merged commit 23853ac into mruby:master Mar 7, 2014

1 check passed

Details default The Travis CI build passed
@ksss ksss added a commit to ksss/mruby that referenced this pull request Mar 8, 2014
@ksss ksss fix #1823 d7b1794
@ghost Unknown pushed a commit to iij/mruby that referenced this pull request Mar 11, 2014
@matz matz Hash#== and eql? should not return fixnum; ref #1823 ceae257
@ghost Unknown pushed a commit to iij/mruby that referenced this pull request Mar 11, 2014
@ksss ksss fix #1823 ee7c396
@ksss ksss deleted the ksss:hash-eql branch Mar 16, 2014
@mattn mattn added a commit to mattn/mruby that referenced this pull request Sep 11, 2015
@matz matz Hash#== and eql? should not return fixnum; ref #1823 1ab8e4c
@mattn mattn added a commit to mattn/mruby that referenced this pull request Sep 11, 2015
@ksss ksss fix #1823 59354d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.