mrdb: add and use mrb_debug_{str,strn}dup() #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They behave similar to their POSIX equivalents, except mrb_malloc_simple() is used for memory allocation and errno might not be set since ISO C99 doesn't have ENOMEM.
As they are safer to use than mrb_malloc()+strlen()+strncpy() (see mruby#2652).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cc: @mimaki)
I think it's a good idea to add and use these functions, because they're easier and safer (see #2652) to use than the previous (varying) combination of functions calls (
mrb_malloc()+strlen()+strncpy()orstrcpy()). They also simplify reading and maintaining the code a bit.I'm unsure about the two new files, but I was also unsure about adding the functions to libmruby itself (
src/gc.c).