Merged
Conversation
added 3 commits
August 22, 2015 10:18
Removed old mrbgems_test.rake which was merged into mrbgem spec
Contributor
Author
Member
|
I like the concept of the PR, but Tavis failed. |
Contributor
Author
|
@matz Yeah I can reproduce the travis failure locally with |
Contributor
Author
|
So I've narrowed it down to when |
added 2 commits
September 1, 2015 20:54
We have do this because mruby's test files are found using MRUBY_ROOT, like this:
mrbs = Dir.glob("#{MRUBY_ROOT}/test/t/*.rb")
Contributor
Author
|
The build is green as of 87564dc! <3 |
zzak
pushed a commit
to zzak/mruby
that referenced
this pull request
Sep 3, 2015
This allows us to add `enable_test` anywhere in a build target, without having to worry about the order in which they are included. Previously, there was a bug that occured when adding 'mruby-test' gem to dependencies before additional gems. Instead of adding the 'mruby-test' gem dependency manually to a test build, we now only need to call `enable_test` in the target. This also allows us to call `test_enabled?` downstream when compiling mruby ourselves. /cc mruby#2924
zzak
pushed a commit
to zzak/mruby
that referenced
this pull request
Sep 3, 2015
This allows us to add `enable_test` anywhere in a build target, without having to worry about the order in which they are included. Previously, there was a bug that occured when adding 'mruby-test' gem to dependencies before additional gems. Instead of adding the 'mruby-test' gem dependency manually to a test build, we now only need to call `enable_test` in the target. This also allows us to call `test_enabled?` downstream when running mruby tests ourselves. /cc mruby#2924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to create specific target
MRuby::Builds for our tests.Previously the test library, and optionally the binary, were compiled for every build.