/mruby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable d098d82 for shortcut operator temporarily #3159

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mame @matz
@mame
Contributor

mame commented May 14, 2016

d098d82 introduces a stack inconsistency when it is a shortcut operator.

a = { :foo => { :bar => 0 } }
p((a[:foo] ||= {})[:bar] ||= 42)
#=> expected: 0, actual: nil

Note that this is just a temporary fix to disable d098d82; a in a[b] ||= c is evaluated twice.
@mame
disable d098d82 for shortcut operator temporarily 
d098d82 introduces a stack inconsistency when it is a shortcut operator.

  a = { :foo => { :bar => 0 } }
  p((a[:foo] ||= {})[:bar] ||= 42)
    #=> expected: 0, actual: nil

Note that this is just a temporary fix to disable d098d82; `a` in `a[b] ||= c` is evaluated twice.
Loading status checks…
292b48e

@matz matz closed this in 29d3a40 May 15, 2016

@matz

This comment has been minimized.

Show comment
Hide comment
@matz

matz May 15, 2016

Member

29d3a40 causes TravisCI fail. need to fix.
Member

matz commented May 15, 2016

29d3a40 causes TravisCI fail. need to fix.

@matz matz reopened this May 15, 2016

@matz matz closed this in 6b0299f May 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment