New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing MRB_API #3215

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@kou
Contributor

kou commented Sep 23, 2016

MRB_API is used implementation in load.c:

MRB_API mrb_irep*
mrb_read_irep_file(mrb_state *mrb, FILE* fp)
Add missing MRB_API
MRB_API is used implementation in load.c:

    MRB_API mrb_irep*
    mrb_read_irep_file(mrb_state *mrb, FILE* fp)
@matz

This comment has been minimized.

Show comment
Hide comment
@matz

matz Sep 23, 2016

Member

I considered mrb_read_irep_file() to be an internal function. Do you have any use-case of the function?

Member

matz commented Sep 23, 2016

I considered mrb_read_irep_file() to be an internal function. Do you have any use-case of the function?

@kou

This comment has been minimized.

Show comment
Hide comment
@kou

kou Sep 23, 2016

Contributor

I don't have any use-case. I just want to build (link) error.
Could you remove MRB_API in load.c?

Contributor

kou commented Sep 23, 2016

I don't have any use-case. I just want to build (link) error.
Could you remove MRB_API in load.c?

@kou kou closed this Sep 23, 2016

@kou

This comment has been minimized.

Show comment
Hide comment
@kou

kou Sep 23, 2016

Contributor

I just want to "fix" build (link) error...

Contributor

kou commented Sep 23, 2016

I just want to "fix" build (link) error...

@matz

This comment has been minimized.

Show comment
Hide comment
@matz

matz Sep 23, 2016

Member

I see inconsistency. Will fix.

Member

matz commented Sep 23, 2016

I see inconsistency. Will fix.

matz added a commit that referenced this pull request Sep 23, 2016

kou added a commit to kou/mruby that referenced this pull request Sep 25, 2016

Remove needless MRB_API
ref #3215

If a function (such as mrb_read_irep_file()) is declared without MRB_API
in header file (such as include/mruby/dump.h), implementation of the
function in source file (such as src/load.c) should also defined without
MRB_API.

If MRB_API is mismatch, Visual C++ reports link error with C2375 error
code: https://msdn.microsoft.com/en-us/library/5k6kw95a.aspx

@kou kou referenced this pull request Sep 25, 2016

Merged

Remove needless MRB_API #3216

@kou kou deleted the kou:add-missing-mrb-api branch Sep 25, 2016

@kou

This comment has been minimized.

Show comment
Hide comment
@kou

kou Sep 25, 2016

Contributor

Thanks. But I found more same cases. I created a new pull request as #3216.

Contributor

kou commented Sep 25, 2016

Thanks. But I found more same cases. I created a new pull request as #3216.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment