Inline structure data type for mruby (MRB_TT_INLINE) #3251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline structures have no instance variables, no finalizer, and offer as much space as possible in RBASIC object. This means 24 bytes on 64-bit platforms and 12 bytes on 32-bit platforms. mruby-inline-struct gem is only provided for testing.
|
Nice idea&implementation. I will merge this after small modifications. |
matz
added a commit
that referenced
this issue
Nov 17, 2016
matz
added a commit
that referenced
this issue
Nov 17, 2016
bundled testing gems do not need to be included in default.gembox. all gems under mrbgems are linked automatically in the test process.
|
merged. thank you! |
|
Great! Thanks for including these changes so quickly. I also measured performance boost in |
|
nice. |
Closed
|
cc #3140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
New data type
MRB_TT_INLINEis introduced.Inline structures have no instance variables, no finalizer, and offer as much space as possible in RBASIC object. This means 24 bytes on 64-bit platforms and 12 bytes on 32-bit platforms. Inline structures are always copied by value.
Only additions to core are 3 simple inline methods in
inline.h. No extra classes are introduced. No C and/or Ruby gem code is added.mruby-inline-structgem is only provided for testing.Fixes #3237.