Reimplements Range#first #3261
Merged
Reimplements Range#first #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Range#first shouldn't call `Range#to_a` on infinity range.
dabroz
reviewed
Nov 21, 2016
|
|
||
| raise ArgumentError, "wrong number of arguments (given #{args.length}, expected 1)" unless args.length == 1 | ||
| nv = args[0] | ||
| raise TypeError, "no implicit conversion from nil to integer" unless nv.nil?.! |
There was a problem hiding this comment.
We could simplify that to if nv.nil?
There was a problem hiding this comment.
I just wanted to unify unless with raise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range#firstwith argument works likeEnumerable#take.Range#firstshouldn't callRange#to_aon infinity range.So, I reimplemented
Range#firstwith Ruby code.Because it hard to write
breakin iterator on C functions.And this implementation passed specs of that https://github.com/ruby/spec/blob/66daf290cb49707190481b4cf24e700010cd53bf/core/range/first_spec.rb
(I know that it's a bit too strictly)