New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite mrb_ary_splice #3409

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
2 participants
@ksss
Contributor

ksss commented Jan 22, 2017

Referenced to CRuby's array.c(rb_ary_splice)

fix #3405

ary = Array.new(1024)
ary[0x7ffffc00,1024] = Array.new(1024)
#=> index 2147482624 too big (IndexError)

It's also passed #3354

ary = Array.new(1023)
ary[0x7ffffc00,0] = Array.new(1024)
#=> index 2147482624 too big (IndexError)

And count of fails in mruby-spec doesn't change(5 fails).

I'm not confident about GC... Please review.

Rewrite mrb_ary_splice
Referenced to CRuby's array.c(rb_ary_splice)

fix #3405

@matz matz merged commit 9d0f07e into mruby:master Jan 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

matz added a commit that referenced this pull request Jan 23, 2017

matz added a commit that referenced this pull request Jan 23, 2017

@ksss ksss deleted the ksss:mrb_ary_splice branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment