New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same format between Fail and Skip #3876

merged 1 commit into from Dec 9, 2017
Jump to file or symbol
Failed to load files and symbols.
+3 −2
Diff settings


Just for now

Use same format between Fail and Skip

We can see gem name in skip message by this fix
  • Loading branch information...
bamchoh committed Dec 8, 2017
commit 81dc383291fa5c31e0b07983ae5ba8a2906e0719
@@ -20,7 +20,8 @@ def t_print(*args)
def assertion_string(err, str, iso=nil, e=nil, bt=nil)
msg = "#{err}#{str}"
msg += " [#{iso}]" if iso && iso != ''
msg += " => #{e.message}" if e
msg += " => #{e.cause}" if e && e.respond_to?(:cause)
msg += " => #{e.message}" if e && !e.respond_to?(:cause)
msg += " (mrbgems: #{GEMNAME})" if Object.const_defined?(:GEMNAME)
if $mrbtest_assert && $mrbtest_assert.size > 0
$mrbtest_assert.each do |idx, assert_msg, diff|
@@ -56,7 +57,7 @@ def assert(str = 'Assertion failed', iso = '')
rescue Exception => e
bt = e.backtrace if $mrbtest_verbose
if e.class.to_s == 'MRubyTestSkip'
$asserts.push "Skip: #{str} #{iso} #{e.cause}"
$asserts.push(assertion_string('Skip: ', str, iso, e, nil))
$asserts.push(assertion_string("#{e.class}: ", str, iso, e, bt))
ProTip! Use n and p to navigate between commits in a pull request.