Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mrbc option `--remove-lv` #4068

Merged
merged 3 commits into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@yurie
Copy link
Contributor

yurie commented Jul 9, 2018

  • refactor: move irep_remove_lv from mruby-bin-strip gem to src/dump and rename to mrb_irep_remove_lv
  • add: mrbc option --remove-lv to remove LVAR section
add mrbc option `--remove-lv`
* refactor: move `irep_remove_lv` from `mruby-bin-strip` gem to src/dump and rename to `mrb_irep_remove_lv`
* add: mrbc option `--remove-lv` to remove LVAR section
@matz

This comment has been minimized.

Copy link
Member

matz commented Jul 9, 2018

The fundamental idea seems OK but is src/dump.c is the best place for mrb_irep_remove_lv?
It seems unnecessary for most of the cases. Maybe in codegen.c?

@yurie

This comment has been minimized.

Copy link
Contributor Author

yurie commented Jul 10, 2018

Updated.
Now declaration of the function is in dump.h. Should I move to irep.h or other file?

@matz

This comment has been minimized.

Copy link
Member

matz commented Jul 10, 2018

irep.h seems better. Besides that, should we provide an option to remove all debug information altogether, not just lv?

@mimaki

This comment has been minimized.

Copy link
Contributor

mimaki commented Jul 11, 2018

@yurie

This comment has been minimized.

Copy link
Contributor Author

yurie commented Jul 11, 2018

moved to irep.h.

Summary of output debug information of mrbc with this patch:

  • (no option): IREP, LVAR sections
  • -g option: IREP, DBG, LVAR sections
  • --remove-lv option: IREP sections

@matz matz merged commit e3bc680 into mruby:master Jul 11, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.