Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dinko Galetic & Denis Kasak noticed that strings beginning with
\xff
can cause a crash instr_squeeze
becauses[0]
is treated as a signed value, causing it to be equal tolastch
, which is -1. After this occurs,i
is decremented ands[-1]
is accessed.The following inputs demonstrate crashes:
Changing
s
to anunsigned char *
fixes the problem.