Skip to content

Improve compatibility to CRuby for Float#to_s #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matz merged 2 commits into from
Jan 14, 2019
Merged

Improve compatibility to CRuby for Float#to_s #4225

matz merged 2 commits into from
Jan 14, 2019

Conversation

@shuujii
Copy link
Contributor

@shuujii shuujii commented Jan 13, 2019

Bfore:

p Float::INFINITY.to_s  #=> "inf"
p 50.0.to_s             #=> "50"
p 1e20.to_s             #=> "1e+20"

After / CRuby:

p Float::INFINITY.to_s  #=> "Infinity"
p 50.0.to_s             #=> "50.0"
p 1e20.to_s             #=> "1.0e+20"

@shuujii
Improve compatibility to CRuby for Float#to_s
9f08118 
Bfore:

  Float::INFINITY.to_s  #=> "inf"
  50.0.to_s             #=> "50"
  1e20.to_s             #=> "1e+20"

After / CRuby:

  Float::INFINITY.to_s  #=> "Infinity"
  50.0.to_s             #=> "50.0"
  1e20.to_s             #=> "1.0e+20"
@shuujii
Use 2 digits exponent format for printf family on old MSVC
0e04c46 
For conforming C standard.
@matz matz merged commit 348526e into mruby:master Jan 14, 2019
@shuujii shuujii deleted the improve-compatibility-to-cruby-for-float-to_s branch January 16, 2019 14:57
@shuujii shuujii mentioned this pull request Apr 5, 2019
Closed
@take-cheeze
Copy link
Contributor

take-cheeze commented Sep 6, 2019

Not a revert request but we should be careful that mruby promotes overflowed integer since mruby doesn't have BigInt.
Related issues cause by this PR:
mattn/mruby-json#40
pepabo/mruby-msd#13
mattn/mruby-json#42

@matz
Copy link
Member

matz commented Sep 6, 2019

OK, I will revert part of this PR.

matz added a commit that referenced this pull request Sep 7, 2019
@matz
Revert part of #4225
9d08025 
Since in mruby, Integer and Float interchange frequently (mostly on
overflow), so adding explicit `.0` can cause problems sometimes.

For example:
mattn/mruby-json#40
pepabo/mruby-msd#13
mattn/mruby-json#42
@matz
Copy link
Member

matz commented Sep 7, 2019

So I removed explicit .0 addition at the end from Float#to_s. @take-cheeze could you check it solves mrbgems problems?

@take-cheeze
Copy link
Contributor

take-cheeze commented Sep 9, 2019

LGTM now

@matz
Copy link
Member

matz commented Sep 9, 2019

Thank you.

@shuujii
Copy link
Contributor Author

shuujii commented Sep 10, 2019

Is it okay in the case of exponential notation? (e.g. 3.0e+45)

@matz
Copy link
Member

matz commented Sep 10, 2019

I think so. The only reason I tried to remove the trailing .0 is integer compatibility, so exponential notation is not included.

shuujii added a commit to shuujii/mruby that referenced this pull request Oct 25, 2019
@shuujii
Always add trailing .0 in Float#inspect; ref mruby#4225
cc9eacb 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test.

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
shuujii added a commit to shuujii/mruby that referenced this pull request Oct 25, 2019
@shuujii
Always add trailing .0 in Float#inspect; ref mruby#4225
5fb873c 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Aug 19, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
3f35ac9 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Aug 20, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
d92353b 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Aug 31, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
40cd184 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Sep 17, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
2ffab1a 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Sep 18, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
0a41f69 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Sep 29, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
2846691 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
matz pushed a commit that referenced this pull request Oct 14, 2020
@shuujii @matz
Always add trailing .0 in Float#inspect; ref #4225
8bd1bc4 
Trailing `.0` is removed from `Float#to_s` and `Float#inspect` at
9d08025. However, I think the more human-readable format is better
for `Float#inspect`.

For example, in the `Float#to_s` format, the failure message is not
well understood when testing values including types by `eql?` (e.g.
`Numeric#step` test).

  ```ruby
  assert "example" do
    exp = 1.0
    act = 1
    assert_operator(exp, :eql?, act)  #=> Expected 1 to be eql? 1.
  end
  ```
ksekimoto added a commit to ksekimoto/mruby that referenced this pull request Jul 16, 2021
@ksekimoto
Merge pull request mruby#4225 from shuujii/improve-compatibility-to-c…
bdc82c0 
…ruby-for-float-to_s

Improve compatibility to CRuby for `Float#to_s`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuujii @take-cheeze @matz