Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility to CRuby for `Float#to_s` #4225

Merged

Conversation

Projects
None yet
2 participants
@shuujii
Copy link
Contributor

commented Jan 13, 2019

Bfore:

p Float::INFINITY.to_s  #=> "inf"
p 50.0.to_s             #=> "50"
p 1e20.to_s             #=> "1e+20"

After / CRuby:

p Float::INFINITY.to_s  #=> "Infinity"
p 50.0.to_s             #=> "50.0"
p 1e20.to_s             #=> "1.0e+20"

shuujii added some commits Jan 13, 2019

Improve compatibility to CRuby for `Float#to_s`
Bfore:

  Float::INFINITY.to_s  #=> "inf"
  50.0.to_s             #=> "50"
  1e20.to_s             #=> "1e+20"

After / CRuby:

  Float::INFINITY.to_s  #=> "Infinity"
  50.0.to_s             #=> "50.0"
  1e20.to_s             #=> "1.0e+20"

@matz matz merged commit 348526e into mruby:master Jan 14, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shuujii shuujii deleted the shuujii:improve-compatibility-to-cruby-for-float-to_s branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.