Fix mruby-io #4712
Merged
Fix mruby-io #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IO#readline` and `IO#readchar` process in character units.
Character (multi-byte UTF-8) is destroyed when character spanning
`IO::BUF_SIZE` (4096 bytes) exist.
- Prepare file:
```ruby
File.open("sample", "wb") { |f| f << "●" * 1370 }
```
- Before patched:
```ruby
File.open("sample") { |f| a = []; while ch = f.getc; a << ch; end; p a }
# => ["●", "●", ..., "●", "\xe2", "\x97", "\x8f", "●", "●", "●", "●"]
- After patched:
```ruby
File.open("sample") { |f| a = []; while ch = f.getc; a << ch; end; p a }
# => ["●", "●", ..., "●", "●", "●", "●", "●", "●"]
matz
added a commit
that referenced
this pull request
Apr 28, 2020
matz
added a commit
that referenced
this pull request
Apr 28, 2020
- mrb_utf8len() - returns the size of a UTF-8 char (in bytes) - mrb_utf8_strlen() - returns the length of a UTF-8 string (in char)
matz
added a commit
that referenced
this pull request
Apr 28, 2020
This fix only effective when `MRB_UTF8_STRING` is set.
mimaki
pushed a commit
to mruby-Forum/mruby
that referenced
this pull request
May 7, 2020
The bug was introduced by mruby#4712. The `getc' problem resurrected. It should be addressed soon.
mimaki
pushed a commit
to mruby-Forum/mruby
that referenced
this pull request
May 7, 2020
- mrb_utf8len() - returns the size of a UTF-8 char (in bytes) - mrb_utf8_strlen() - returns the length of a UTF-8 string (in char)
mimaki
pushed a commit
to mruby-Forum/mruby
that referenced
this pull request
May 7, 2020
This fix only effective when `MRB_UTF8_STRING` is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
"Fix broken UTF-8 characters by
IO#getc" (992ba47) increases the object code size withoutMRB_UTF8_STRINGtoo, so I would like to improve if there is a better solution (but no idea).