Absolute path for windows #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Mar 7, 2020
| @@ -282,7 +282,12 @@ mrb_file__getwd(mrb_state *mrb, mrb_value klass) | |||
| static int | |||
| mrb_file_is_absolute_path(const char *path) | |||
| { | |||
| #ifdef _WIN32 | |||
| if (strlen(path) < 2) return 0; | |||
| return path[0] >= 64 && path[0] <= 90 && path[1] == ':'; // 64 to 90 is ASCII | |||
There was a problem hiding this comment.
It is not enoguh to check paths with slash or backslash. And "c:" is not absolute paths on Windows.
#define IS_PATHSEP(x) (x == '/' || x == '\')
return (isalpha(path[0]) && path[1] == ':' && IS_PATHSEP(path[2]));
#undef IS_PATHSEPAlso if you want to handle UNC paths, it should check more strictly.
There was a problem hiding this comment.
I will adjust it like the source in ruby. just found out about UNC thanks
matz
added a commit
that referenced
this pull request
Mar 7, 2020
matz
added a commit
that referenced
this pull request
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mirb
Result in windows
I have added some code for this. I like it when combined :)