-
Notifications
You must be signed in to change notification settings - Fork 814
Add ObjectSpace.memsize_of_all #5040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoryO
commented
Jul 18, 2020
@@ -1,4 +1,3 @@ | |||
# coding: cp932 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry I think I introduced this initially. I did not catch that ruby-mode
adds the encoding comment.
matz
reviewed
Jul 18, 2020
matz
added a commit
that referenced
this pull request
Jul 18, 2020
`ObjectSpace.memsize_of_all` takes a class and count memory size of all instances of the class and its subclasses (if any).
matz
added a commit
that referenced
this pull request
Jul 18, 2020
I updated a little.
|
@RoryO Thank you for the contribution. Would you like to add your name to the |
matz
added a commit
that referenced
this pull request
Jul 19, 2020
matz
added a commit
that referenced
this pull request
Jul 19, 2020
matz
added a commit
that referenced
this pull request
Jul 19, 2020
matz
added a commit
that referenced
this pull request
Jul 19, 2020
Those tests succeeds only on some configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much simpler and I hope less error prone than before.