Avoid exposure for REnv objects
#5945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `REnv` object is difficult to deal with, and it would be ideal if the user did not have to manipulate it directly. In some previous situations, it was necessary to call `mrb_env_unshare()`, a non-API function, after `mrb_load_string()` or similar. With this patch, it is no longer necessary for users to use `mrb_env_unshare()` directly, as it is now handled internally simply by using the `mrb_vm_ci_env_clear()` function. Also, `mrb_vm_ci_env_set()` is demoted from the `MRB_API` function for the same reason. ref. commit 1ab3da6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
REnvobject is difficult to deal with, and it would be ideal if the user did not have to manipulate it directly. In some previous situations, it was necessary to callmrb_env_unshare(), a non-API function, aftermrb_load_string()or similar.With this patch, it is no longer necessary for users to use
mrb_env_unshare()directly, as it is now handled internally simply by using themrb_vm_ci_env_clear()function. Also,mrb_vm_ci_env_set()is demoted from theMRB_APIfunction for the same reason.ref. commit 1ab3da6