Demotion mrb_f_raise() in kernel.c from MRB_API too - #6070
Merged
Conversation
kou
pushed a commit
to groonga/groonga
that referenced
this pull request
Sep 27, 2023
Because the performance of Groonga degrades when presym disable. In addition, the mruby's issues about escape has arleady fixed in upstream as below probably. mruby/mruby@03a42b5 mruby/mruby@25f3608 Therefore, we use the master branch of mruby( 15bb6a9f9b9b114b97cfa18631c46be90669adde ) in this PR. But the revision has a MRB_API problem. mruby/mruby#6070 should fix it.
The prototype declaration of mrb_f_raise() has arleady demoted from MRB_API in a below commit. mruby@0898ce9 However, the entity of mrb_f_raise() in kernel.c is set MRB_API yet. Therefore, mruby occures build error with MSVC(in Visual Studio 2022) as below. https://github.com/groonga/groonga/actions/runs/6310140553/job/17131485675#step:11:2067 The cause of the above error that we define both mrb_f_raise() with MRB_API and mrb_f_raise() without MRB_API.
komainu8
force-pushed
the
demotion-mrb_f_raise-from-mrb_api
branch
from
September 28, 2023 00:18
f5f61b8 to
d55cec4
Compare
kou
added a commit
to groonga/groonga
that referenced
this pull request
Sep 28, 2023
We will use mruby/mruby again after mruby/mruby#6070 is merged.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prototype declaration of
mrb_f_raise()has arleady demoted fromMRB_APIin a below commit.0898ce9
However, the entity of
mrb_f_raise()in kernel.c is setMRB_APIyet.Therefore, mruby occures build error with MSVC(in Visual Studio 2022) as below.
https://github.com/groonga/groonga/actions/runs/6310140553/job/17131485675#step:11:2067
The cause of the above error that we define both
mrb_f_raise()withMRB_APIandmrb_f_raise()withoutMRB_API.The results of
rake testof this PR.