Fix MRUBY_PACKAGE_DIR in mruby-config.bat#6174
Merged
matz merged 1 commit intomruby:masterfrom Feb 17, 2024
Merged
Conversation
Previously, the correct directory could not be obtained in some environments. Therefore, changed the method to leave an element indicating the parent directory. fix mruby#6156
jbampton
reviewed
Feb 17, 2024
Contributor
jbampton
left a comment
jbampton
left a comment
There was a problem hiding this comment.
The link is valid so the pre-commit check failure is just a false positive.
In future we may need to add a config file for the markdown-link-check.
https://github.com/tcort/markdown-link-check?tab=readme-ov-file#config-file-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the correct directory could not be obtained in some environments.
Therefore, changed the method to leave an element indicating the parent directory.
fix #6156