Add a way to let other gems handle closing of fds in mruby-io#6231
Merged
Conversation
Contributor
Author
|
A short explanation: i'm writing a mruby gem to implement io_uring from linux. I've tried several ways to fix this in my gem, the only thing that worked is to mrb_gc_register every mruby-io object i created and never unregister them, because you can't know when its save to release them. |
matz
added a commit
that referenced
this pull request
Apr 11, 2024
The `sizeof(struct mrb_io)` is reduced from 32 bytes to 24 bytes on x86_64-linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently writing a gem which wants to integrate with mruby-io and mruby-socket.
At the moment mruby-io closes fds it didn't create itself and thus can cause problems when other gems except the fd to still be available.
This only changes how
fptr_finalizehandles the closing of fds and nothing else.I've tried handling that in my gem by stopping a created mruby-io object from being garbage collected until it's not needed anymore, but that wasn't enough.