Remove exc_caught from mrb_vm_exec()#6260
Merged
Merged
Conversation
Only go to exception handling if `mrb->exc` is non-null. This may cause some compatibility problems, but I doubt that it is necessary to maintain that compatibility. Here is how I see the incompatibility with the change at this time: - If `mrb->exc` is non-null and `mrb_vm_exec()` is called, an exception will be thrown immediately. - If `MRB_THROW()` is used while `mrb->exc` is `NULL`, it will not go to exception handling.
Contributor
Author
|
As a note, write down what I am thinking further as a change in behavior.
Put
Put |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only go to exception handling if
mrb->excis non-null.This may cause some compatibility problems, but I doubt that it is necessary to maintain that compatibility.
Here is how I see the incompatibility with the change at this time:
mrb->excis non-null andmrb_vm_exec()is called, an exception will be thrown immediately.MRB_THROW()is used whilemrb->excisNULL, it will not go to exception handling.