Allow to change the output directory name of the libmruby file#6290
Merged
Conversation
Add the `MRuby::Build#libdir_name` accessor and the `MRUBY_SYSTEM_LIBDIR_NAME` environment variable. Resolved mruby#6240
mkoncek
reviewed
Jun 9, 2024
| ### Name of library directory | ||
|
|
||
| In some environments, the `libmruby.a` file requires a different directory name than `lib`. | ||
| You can be changed to any name by the `conf.libdir_name` accessor. |
There was a problem hiding this comment.
My suggestion for the sentence is:
This directory can be changed to a different name using the `conf.libdir_name` accessor.
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion. Unfortunately this time the merge was faster than I can check.
I am only converting from Japanese to English using DeepL. So I would be very grateful if you could improve the English text.
If you don't mind, could you please create a PR? Thank you very much.
There was a problem hiding this comment.
Sure, at some point I can go over the whole text, although I am also not a native speaker...
Contributor
Author
There was a problem hiding this comment.
Okay, I will not say anything unreasonable.
Please let us know if you have any further concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
MRuby::Build#libdir_nameaccessor and theMRUBY_SYSTEM_LIBDIR_NAMEenvironment variable.Resolved #6240
I was thinking too hard when I commented on #6240.
This PR limits the modification of
lib/to the build task (as described in the documentation).