Omit error checking at OP_RETURN, OP_RETURN_BLK and OP_BREAK - #6312
Merged
Conversation
Clearing errors at the beginning of `mrb_vm_exec()` essentially keeps the mruby VM in a non-error state. For consistency, functions such as `mrb_funcall()` check for errors when control returns from a C function as a method. In the case of a tail call, it should return to `mrb_vm_exec()` afterwards, so error checking is performed there. Instructions issued while `mrb->exc` is non-null should be limited to `OP_EXCEPT`, the jump target of the catch handler table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing errors at the beginning of
mrb_vm_exec()essentially keeps the mruby VM in a non-error state.For consistency, functions such as
mrb_funcall()check for errors when control returns from a C function as a method. In the case of a tail call, it should return tomrb_vm_exec()afterwards, so error checking is performed there.Instructions issued while
mrb->excis non-null should be limited toOP_EXCEPT, the jump target of the catch handler table.