fix ncurses linking issues#6327
Merged
Merged
Conversation
The build configuration for `mruby` assumes only the `ncurses` library needs to be linked because `tinfo` is implicitly pulled in. In environments where ncurses is available only as a static library, `tinfo` needs to be linked explicitly (needed for functions like `tputs`. This patch fixes that by linking `tinfo` if available. It also fixes the build for environments where only the `ncursesw` version of the library (including wide character support) is present, while still giving preference to the `ncurses` version (without wide character support).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build configuration for
mrubyassumes only thencurseslibrary needs to be linked becausetinfois implicitly pulled in.In environments where ncurses is available only as a static library,
tinfoneeds to be linked explicitly (needed for functions liketputs.This patch fixes that by linking
tinfoif available.It also fixes the build for environments where only the
ncurseswversion of the library (including wide character support) is present, while still giving preference to thencursesversion (without wide character support).