Fix argument forwarding in mrb_exec_irep() - #6392
Merged
Merged
Conversation
C to Ruby calls using `mrb_exec_irep()` were not forwarding arguments. There was also a problem in setting the target class and method ID, which is also fixed. This issue was discovered during the work to fix mruby#6389.
dearblue
added a commit
to dearblue/mruby
that referenced
this pull request
Oct 25, 2024
The mruby#6392 has been merged, so the call to `mrb_yield_with_class()` is no longer needed.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C to Ruby calls using
mrb_exec_irep()were not forwarding arguments.There was also a problem in setting the target class and method ID, which is also fixed.
This issue was discovered during the work to fix #6389.
This patch was tested by customizing #6391.