Skip to content

boxing_no.h: rename BOXNIX_SET_VALUE -> BOXNO_SET_VALUE - #6397

Merged
matz merged 1 commit into
mruby:masterfrom
wataash:boxno-set-value
Nov 1, 2024
Merged

boxing_no.h: rename BOXNIX_SET_VALUE -> BOXNO_SET_VALUE#6397
matz merged 1 commit into
mruby:masterfrom
wataash:boxno-set-value

Conversation

@wataash

@wataash wataash commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

I want to rename it because I was confused about what NIX meant.

@wataash
wataash requested a review from matz as a code owner October 31, 2024 07:06
@github-actions github-actions Bot added the core label Oct 31, 2024
@matz

matz commented Nov 1, 2024

Copy link
Copy Markdown
Member

Boxing_no. h was originally boxing_nix. h. When we renamed the header file, we should have renamed macro names as well. I accept the renaming.

@matz
matz merged commit 16ae9e6 into mruby:master Nov 1, 2024
@wataash
wataash deleted the boxno-set-value branch November 1, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants