Skip to content

Change MRB_WITH_IO_PREAD_PWRITE configuration name - #6450

Merged
matz merged 1 commit into
mruby:masterfrom
dearblue:io-pread-pwrite
Dec 12, 2024
Merged

Change MRB_WITH_IO_PREAD_PWRITE configuration name#6450
matz merged 1 commit into
mruby:masterfrom
dearblue:io-pread-pwrite

Conversation

@dearblue

@dearblue dearblue commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Change to MRB_USE_IO_PREAD_PWRITE for consistency with mruby configuration macros.
Similarly, MRB_WITHOUT_IO_PREAD_PWRITE is changed to MRB_NO_IO_PREAD_PWRITE.

The previous names are available for compatibility but are deprecated.

@matz

matz commented Dec 12, 2024

Copy link
Copy Markdown
Member

This PR needs to be rebased.

@dearblue

Copy link
Copy Markdown
Contributor Author

Ah, thank you.
I had not noticed the conflict.

Change to `MRB_USE_IO_PREAD_PWRITE` for consistency with mruby configuration macros.
Similarly, `MRB_WITHOUT_IO_PREAD_PWRITE` is changed to `MRB_NO_IO_PREAD_PWRITE`.

The previous names are available for compatibility but are deprecated.
@matz
matz merged commit 9170666 into mruby:master Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants