Add File.absolute_path? method

[dearblue]

No description provided.

[gemini-code-assist]

Hello @dearblue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds a new method File.absolute_path? to the mruby-io gem. This method checks if a given path is an absolute path. The implementation includes the core C code for the method and its Ruby binding, as well as test cases to verify its behavior on both Windows and non-Windows platforms.

Highlights

• New Method: Introduces File.absolute_path? to determine if a path is absolute.
• Platform Specific Tests: Includes platform-specific tests for Windows and non-Windows systems to ensure correct behavior.
• C Implementation: Implements the core logic for File.absolute_path? in C for performance.

Changelog

• mrbgems/mruby-io/src/file.c
  • Added mrb_file_absolute_path_p function to check if a path is absolute.
  • Registered File.absolute_path? as a class method in mrb_init_file.
• mrbgems/mruby-io/test/file.rb
  • Added test cases for File.absolute_path?.
  • Includes conditional tests based on the platform (Windows or non-Windows).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A path can wind, a file can hide,
But absolute_path? brings truth to light.
Through tests it runs, on every node,
Ensuring code works just right.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new method File.absolute_path? to check if a given path is absolute. The implementation seems correct and includes tests for both Windows and non-Windows platforms. However, there are a few minor suggestions for improvement.

Merge Readiness

The code changes are well-structured and include comprehensive tests. I recommend merging this pull request after addressing the identified medium severity issue. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.

[gemini-code-assist]

Consider adding a brief comment explaining what this function does. This can improve readability and maintainability.

Suggested change

	static mrb_value
	mrb_file_absolute_path_p(mrb_state *mrb, mrb_value klass)
	{
	mrb_value path = mrb_get_arg1(mrb);
	mrb_ensure_string_type(mrb, path);
	return mrb_bool_value(path_absolute_p(RSTRING_CSTR(mrb, path)));
	}
	/*
	* Checks if a path is absolute.
	*/
	static mrb_value
	mrb_file_absolute_path_p(mrb_state *mrb, mrb_value klass)
	{
	mrb_value path = mrb_get_arg1(mrb);
	mrb_ensure_string_type(mrb, path);
	return mrb_bool_value(path_absolute_p(RSTRING_CSTR(mrb, path)));
	}