add mrbgems/ext/mruby-numeric, and method: Integer#chr #968

Merged
merged 3 commits into from Mar 8, 2013

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Mar 8, 2013

#955 to mrbgems. (not String#chr)

Reference: http://www.ruby-doc.org/core-2.0/Integer.html#method-i-chr

Contributor

mattn commented Mar 8, 2013

I prefer to add failing test to utf-8. mruby doesn't support any encodings. I know the future won't come. But it will be poissible to support utf-8. So I guess, you've better to add failing test for utf-8. For example: 12354.chr raise error.

@ghost

ghost commented Mar 8, 2013

@mattn thank you. I just added test case.

matz added a commit that referenced this pull request Mar 8, 2013

Merge pull request #968 from kouki-o-iij/pr-mrbgem-numeric-ext
add mrbgems/ext/mruby-numeric, and method: Integer#chr

@matz matz merged commit cec2873 into mruby:master Mar 8, 2013

1 check passed

default The Travis build passed
Details

@ghost ghost deleted the pr-mrbgem-numeric-ext branch Mar 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment